[4.5] Metrics view#1091
Conversation
Implements following: - A metrics table widget that is: - vertically and horizontally scrollable with pagination/infinite scrolling - sortable columns (client side) - groupable/collapsible columns - alternate row coloring - refresh button to refresh views - threshold table cell coloring - panel/breadcrumb navigation - quick view action column - translatable labels - Sortable column for all CloudStack tables (client side) - Configurable UI pagesize for list API calls, 'default.ui.page.size' - Metrics views: Zones, Clusters, Hosts, Instances, Storage pools, Volumes - Resource filtering/navigation: Zones->Clusters->Hosts->Instances->Volumes, Storage Pool->Volumes Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
…ances view Add minor features based on community discussions Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com> (cherry picked from commit b4d1fed) Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com> (cherry picked from commit edc74ae) Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Based on suggestion from Lucian (Nux), this patch increases the UI's container width by 200px as most modern resolutions on desktop/laptops/workstations are at least 1400px wide. By increasing the width and adjusting css properties throughout the UI, we get more space to show information. This also gets rid of horizontal scrollbar in case of metrics views. This also, fixes the UI logos to include our mascot 'cloudmonkey'. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com> (cherry picked from commit f7b6472) Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
- Allow all users to see resource metrics - Fix instance count issue on host metrics view - Fix sorting issue Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com> (cherry picked from commit 53084c4) Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
[4.5] Metrics viewFrom #1038, for 4.5 branch * pr/1091: CLOUDSTACK-9020: Metrics UI fixes CLOUDSTACK-9020: Increase UI container width by 200px CLOUDSTACK-9020: add ipaddress in instances view CLOUDSTACK-9020: add instances count in host view, ip address in instances view CLOUDSTACK-9020: Metrics views for CloudStack UI Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
|
Merging on 4.5 based on no objections and popular demands. |
|
Please wait. This lands a feature/fix/enhancement in 4.5 and 4.7 while not in 4.6. This will just confuse the users. This basically means that votes for only in 4.7 on the PR #1038 aren't valid while its already merged. We have diverged opinion here with respect to few wanting it in 4.5+ as enhancement and a few on 4.7+ as a feature. Let us not count them independently as +1. They are actually related. +1 for 4.5+ means -1 for 4.7+ and vice-versa. We decided to fwd-merge stuff and let us please stick to it. |
|
@karuturi I can revert the metrics view feature, but would keep the other css/js improvements wrt sorting etc. Comments? |
|
@remibergsma @karuturi this is confusion, we've been backporting changes for long. These are simply UI changes that don't affect backend/core/mgmt server. I would say, it helps to include them in 4.5/4.6 branches. If there is no strict rule, I want to include them in 4.5 because users are not going to simply upgrade every time we do a major release, it makes sense to backport bugfixes and small changes that can be consumed in minor releases. |
|
I am ok with merging the fix to 4.5+. I am not against that. But, missing one release is not acceptable. Given that its already merged on 4.7, merging in 4.5 now is not an option. I am ok with merging css/js improvements in 4.5+ releases. |
|
For future reference: this PR is reverted in commit ea5aecb |
From #1038, for 4.5 branch