CLOUDSTACK-9057 remove old system vm upgrade code#1061
Closed
DaanHoogland wants to merge 8 commits into
Closed
Conversation
Signed-off-by: Remi Bergsma <github@remi.nl>
Contributor
|
LGTM |
Contributor
|
Since this code is only needed if you upgrade to We should run an upgrade test to verify. |
Contributor
|
I will test the upgrade, @DaanHoogland and LGTM afterwards. Cheers, |
Signed-off-by: Remi Bergsma <github@remi.nl>
implement upgrade path from 4.6.0 to 4.6.1The 4.6 branch needs an upgrade path to 4.6.1. I looked at how this was done before and think this will do. Can you give it a second pair of eyes please @DaanHoogland ? When this is indeed OK, I'll do the same for master for the 4.6.0 -> 4.7.0 path. I've tried a build and that works: `mvn clean install` ``` [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 07:33 min [INFO] Finished at: 2015-11-15T13:45:58+01:00 [INFO] Final Memory: 120M/1591M [INFO] ------------------------------------------------------------------------ ``` Once this is a PR, I'll try an actual upgrade from 4.6.0 to 4.6.1-SNAPSHOT. * pr/1067: implemented upgrade path from 4.6.0 to 4.6.1 Signed-off-by: Remi Bergsma <github@remi.nl>
Contributor
Author
|
@remibergsma @wilderrodrigues @karuturi is anything to be done with this? |
Contributor
|
@DaanHoogland Yes, please make this PR towards 4.6 please. |
d8e7e7d to
d6e7762
Compare
Contributor
Author
|
#1072 contains this code to be merged on 4.6 (and rebased on post-release commit) |
asfgit
pushed a commit
that referenced
this pull request
Nov 20, 2015
CLOUDSTACK-9057 remove old system vm upgrade codereplacing #1061 on release branch for 4.6 * pr/1072: CLOUDSTACK-9057 remove old system vm upgrade code Signed-off-by: Remi Bergsma <github@remi.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the upgrade step to 4.5 system templates is removed for 4.6 in this. validation would be to install any 4.4.2 or lower version and upgrade to 4.6. It would only require the templates for 4.6 and not the ones for 4.5. as it would before this patch. only unittests performed hence for all practical purposes untested.