CLOUDSTACK-9055: fix NPE in updating Redundant State of VPC networks#1059
CLOUDSTACK-9055: fix NPE in updating Redundant State of VPC networks#1059ustcweizhou wants to merge 8 commits into
Conversation
Signed-off-by: Remi Bergsma <github@remi.nl>
|
Please, steps to reproduce/test your PR. Also, write a bit about how you got into this issue in the PR description. In addition, which integration tests did you execute? I don't think it would that hard to elaborate a bit on a PR and give some hints to people that will end up testing it. Cheers, |
There was a problem hiding this comment.
trivial comment: looks like
if (answer != null) {
if (answer.getResult()) {
state = answer.getState();
} else {
s_logger.info("Agent response doesn't seem to be correct ==> " + answer.getResult());
}
}
|
LGTM by code inspection. The issue is obvious and the solution as well. I do agree with @wilderrodrigues that permanent validation of the issue is needed. In this case a ref to a unit test may be enough if it exists. otherwise a marvin/integration test would be fine. |
|
@wilderrodrigues @DaanHoogland This happened when one of nodes is down. I think it will happen when the cloudstack-agent is stopped or killed. |
Signed-off-by: Remi Bergsma <github@remi.nl>
implement upgrade path from 4.6.0 to 4.6.1The 4.6 branch needs an upgrade path to 4.6.1. I looked at how this was done before and think this will do. Can you give it a second pair of eyes please @DaanHoogland ? When this is indeed OK, I'll do the same for master for the 4.6.0 -> 4.7.0 path. I've tried a build and that works: `mvn clean install` ``` [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 07:33 min [INFO] Finished at: 2015-11-15T13:45:58+01:00 [INFO] Final Memory: 120M/1591M [INFO] ------------------------------------------------------------------------ ``` Once this is a PR, I'll try an actual upgrade from 4.6.0 to 4.6.1-SNAPSHOT. * pr/1067: implemented upgrade path from 4.6.0 to 4.6.1 Signed-off-by: Remi Bergsma <github@remi.nl>
|
@ustcweizhou Can you please make this PR against 4.6 branch? After merge it will be fwd-merged to master. Thanks! |
ac4173d to
66fc7c6
Compare
No description provided.