Skip to content

UI: Restore AS Numbers and IPv4 Subnets menus #10580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weizhouapache merged 4 commits into from
Apr 11, 2025
Merged

UI: Restore AS Numbers and IPv4 Subnets menus #10580

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
84a2b04
UI: Restore AS Numbers menu
nvazquez Mar 17, 2025
7dac8bb
Restore IPv4 Subnets menu
nvazquez Mar 17, 2025
6792319
Add missing details for network and VPC details and tabs for Isolated…
nvazquez Mar 17, 2025
34c525a
Address latest review comments
nvazquez Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Address latest review comments
  • Loading branch information
@nvazquez
nvazquez committed Apr 8, 2025
commit 34c525a33539d3365a7a85830055b2be84f2b783
7 changes: 2 additions & 5 deletions ui/src/config/section/network.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ export default {
return fields
},
details: ['name', 'id', 'displaytext', 'cidr', 'networkdomain', 'ip4routing', 'ip4routes', 'ip6routes', 'ispersistent', 'redundantvpcrouter', 'restartrequired', 'zonename', 'account', 'domain', 'dns1', 'dns2', 'ip6dns1', 'ip6dns2', 'publicmtu'],
searchFilters: ['name', 'zoneid', 'domainid', 'account', 'tags'],
searchFilters: ['name', 'zoneid', 'domainid', 'account', 'restartrequired', 'tags'],
related: [{
name: 'vm',
title: 'label.instances',
Expand Down Expand Up @@ -320,10 +320,7 @@ export default {
return false
}
const listZoneHaveSGEnabled = store.getters.zones.filter(zone => zone.securitygroupsenabled === true)
if (!listZoneHaveSGEnabled || listZoneHaveSGEnabled.length === 0) {
return false
}
return true
return (listZoneHaveSGEnabled && listZoneHaveSGEnabled.length > 0) || store.getters.showSecurityGroups
},
actions: [
{
Expand Down
Loading