Skip to content

vTPM: support KVM and VMware #10543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pearl1594 merged 17 commits into from
Apr 26, 2025
Merged

vTPM: support KVM and VMware #10543

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
c9186a8
KVM: add Virtual TPM model and version
weizhouapache Mar 11, 2025
5378192
KVM: add admin-only VM setting GUEST.CPU.MODE and GUEST.CPU.MODEL
weizhouapache Mar 11, 2025
686b714
VMware: add vTPM
weizhouapache Mar 11, 2025
771dfce
vTPM: do not set Key due to 'Cannot add multiple devices using the sa…
weizhouapache Mar 11, 2025
7f0b828
vTPM: add unit test testTpmModel
weizhouapache Mar 13, 2025
5c90596
engine/schema: remove user vm details for guest CPU mode/model
weizhouapache Mar 13, 2025
aabee5e
vTPM: extra methods as Daan's requests
weizhouapache Mar 13, 2025
3588be7
vTPM: add unit tests in VmwareResourceTest
weizhouapache Mar 14, 2025
6a461b1
vTPM: update unit tests in VmwareResourceTest
weizhouapache Mar 14, 2025
580b1cb
vTPM: add unit test in LibvirtComputingResourceTest
weizhouapache Mar 14, 2025
c74f339
vTPM: use the default TPM version if an invalid version is passed
weizhouapache Mar 14, 2025
81e26ab
vTPM: requires UEFI on vmware and do nothing if it is not enabled/dis…
weizhouapache Mar 17, 2025
8c99e65
vTPM: let uses to add UEFI on vmware
weizhouapache Mar 17, 2025
1c33015
Update plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/…
weizhouapache Mar 19, 2025
310bf89
Update plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/…
weizhouapache Mar 19, 2025
e1a4ed2
vTPM: remove template details for guest CPU mode/model
weizhouapache Mar 28, 2025
8bfd8f8
UI: boot vm from ISO into UEFI/SECURE mode
weizhouapache Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
engine/schema: remove user vm details for guest CPU mode/model
  • Loading branch information
@weizhouapache
weizhouapache committed Mar 13, 2025
commit 5c90596fb9e082065414ba379b6b12a278d0ebe7
3 changes: 3 additions & 0 deletions engine/schema/src/main/resources/META-INF/db/schema-42000to42010.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@
-- Schema upgrade from 4.20.0.0 to 4.20.1.0
--;

-- Delete user vm details for guest CPU mode/model which are root admin only
DELETE FROM `cloud`.`user_vm_details` WHERE `name` IN ('guest.cpu.mode','guest.cpu.model');
Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weizhouapache will this impact any VMs in existing deployments with these settings?

Copy link
Copy Markdown
Member Author

@weizhouapache weizhouapache Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two settings have no impact in older versions, but are only available for root admin with this PR (because I think the host CPU is sensitive information).

I think it is better to remove them during upgrade. Otherwise user can add the settings before upgrade, and get the Host CPU after upgrade.


-- Add column api_key_access to user and account tables
CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.user', 'api_key_access', 'boolean DEFAULT NULL COMMENT "is api key access allowed for the user" AFTER `secret_key`');
CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.account', 'api_key_access', 'boolean DEFAULT NULL COMMENT "is api key access allowed for the account" ');
Expand Down