Skip to content

server: fix pod retrieval during volume attach #10324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaanHoogland merged 8 commits into from
Feb 7, 2025
Merged

server: fix pod retrieval during volume attach #10324

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0f0a1ba
server: fix attach uploaded volume
shwstppr Jan 24, 2025
af21605
fix
shwstppr Jan 27, 2025
0c6b243
Merge remote-tracking branch 'apache/4.19' into fix-volattach-uploaded
shwstppr Jan 27, 2025
da6af2f
fix
shwstppr Jan 27, 2025
4c1548a
add unit tests
shwstppr Jan 27, 2025
9e20c90
Merge branch 'fix-volattach-uploaded' into fix-attachvol-npe
shwstppr Feb 6, 2025
8d95a51
server: fix pod retrieval during volume attach
shwstppr Feb 4, 2025
557b3ba
changes for attaching allocated vol to a stopped vm
shwstppr Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
  • Loading branch information
@shwstppr
shwstppr committed Jan 27, 2025
commit af21605d944298e992fb1b80b053482fffb119c2
3 changes: 2 additions & 1 deletion server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2439,7 +2439,8 @@ protected StoragePool getPoolForAllocatedOrUploadedVolumeForAttach(final VolumeI
volumeToAttach.getName(), volumeToAttach.getId(), volumeToAttach.getSize(), offering.getTagsArray(),
offering.isUseLocalStorage(), offering.isRecreatable(),
volumeToAttach.getTemplateId());
StoragePool pool = _volumeMgr.findStoragePool(diskProfile, zone, pod, clusterHostId.first(), clusterHostId.second(), vm, null);
StoragePool pool = _volumeMgr.findStoragePool(diskProfile, zone, pod, clusterHostId.first(),
clusterHostId.second(), vm, Collections.emptySet());
if (pool == null) {
throw new CloudRuntimeException(String.format("Failed to find a primary storage for volume in state: %s", volumeToAttach.getState()));
}
Expand Down