Update de_DE Localization. Now Web UI 4.6 is fully translated in German#1032
Conversation
|
+1 LGTM just looking at the translated strings. did not build it. |
|
+1 LGTM (ignore jenkins, one of the modules crashed due to jvm issue not code issues) |
|
@bhaisaab I agree that this run on jenkins can be ignored but let's see a successful compile anyhow. I have it in my queue but I will forgive anybody that beats me to it. |
|
@DaanHoogland I figured Travis is green and changes were just in properties file, so looked good to me |
|
ok, travis green does not mean it actually does anything, does it? In this case I think it did compile but none of the tests were run. Maybe that's enough for this one @remibergsma ? |
|
Shouldn't we at least try a compile and see if the UI shows up? |
|
Just did LGTM (logging in as a sturmbahn....) |
|
@DaanHoogland A picture or it didn't happen! ;-) |
|
|
…20151104 Update de_DE Localization. Now Web UI 4.6 is fully translated in GermanLast update to have 100% on German in Web UI Please 2 LGTM before the RC1! Thanks @resmo cc @remibergsma @DaanHoogland @karuturi * pr/1032: Update de_DE Localization. Now Web UI 4.6 is fully translated in German Signed-off-by: Remi Bergsma <github@remi.nl>
Last update to have 100% on German in Web UI
Please 2 LGTM before the RC1!
Thanks @resmo
cc @remibergsma @DaanHoogland @karuturi