Skip to content

Fix nfs route bug#10304

Closed
iishitahere wants to merge 5 commits into
apache:mainfrom
iishitahere:fix-nfs-route-bug
Closed

Fix nfs route bug#10304
iishitahere wants to merge 5 commits into
apache:mainfrom
iishitahere:fix-nfs-route-bug

Conversation

@iishitahere
Copy link
Copy Markdown

@iishitahere iishitahere commented Jan 30, 2025 •
edited by DaanHoogland
Loading

Description

This PR fixes the issue #10163, where the secondary storage VM fails to add a static route to the NFS server, causing a No route to host error. The _storageIp was previously null, resulting in failed route addition (via null).

Changes Made

  • Improved _storageIp handling to prevent null values.
  • Added utility methods to validate NFS server reachability.
  • Enhanced error handling and logging.

Testing

  • Verified successful template uploads to secondary storage.
  • Checked route addition on the SSVM.
  • Ran unit tests (S3TemplateTest, etc.), all tests passed successfully.

@DaanHoogland DaanHoogland mentioned this pull request Jan 31, 2025
Closed
@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Jan 31, 2025

thanks @iishitahere for the PR

I would suggest you keep this PR clean and remove all unnecessary changes
IMHO, this PR could be around 5 lines of code changes

@iishitahere
Copy link
Copy Markdown
Author

iishitahere commented Feb 1, 2025

thanks @iishitahere for the PR

I would suggest you keep this PR clean and remove all unnecessary changes IMHO, this PR could be around 5 lines of code changes

Thank you for your feedback and for reviewing the PR. I sincerely appreciate your guidance.

I apologize for the unnecessary changes. I would like to keep the PR as clean and concise as possible. Could you kindly point out where exactly the code changes are needed so that I can work on it and ensure the PR is focused on resolving the issue effectively?

Thank you for your time and support. I look forward to your response.

Best regards,
Ishita Jaiswal

@shwstppr
Copy link
Copy Markdown
Contributor

shwstppr commented Apr 16, 2025

Closing in favour of #10735
#10163 (comment)

@shwstppr shwstppr closed this Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

component:build component:storage component:UI component:vmware

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iishitahere @weizhouapache @shwstppr