Skip to content

Decrypt zone, cluster, storage details for configuration values #10237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaanHoogland merged 4 commits into from
Feb 3, 2025
Merged

Decrypt zone, cluster, storage details for configuration values #10237

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7093406
Fix retreiving decrypted values from details table for config values
harikrishna-patnala Jan 22, 2025
17c436e
use ResourceDetail interface
harikrishna-patnala Jan 22, 2025
7222779
Use resource Id
harikrishna-patnala Jan 23, 2025
6055ecf
Apply suggestions from code review
DaanHoogland Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review 
Co-authored-by: Bryan Lima <42067040+BryanMLima@users.noreply.github.com>
  • Loading branch information
@DaanHoogland @BryanMLima
DaanHoogland and BryanMLima authored Jan 28, 2025
commit 6055ecf6babc78070b444d8e611cb5fa3e643f9b
4 changes: 2 additions & 2 deletions engine/schema/src/main/java/org/apache/cloudstack/resourcedetail/ResourceDetailsDaoBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
public abstract class ResourceDetailsDaoBase<R extends ResourceDetail> extends GenericDaoBase<R, Long> implements ResourceDetailsDao<R> {

@Inject
private ConfigurationDao _configDao;
private ConfigurationDao configDao;

private SearchBuilder<R> AllFieldsSearch;

Expand Down Expand Up @@ -213,7 +213,7 @@ public List<Long> findResourceIdsByNameAndValueIn(String name, Object[] values)

@Override
public String getActualValue(ResourceDetail resourceDetail) {
ConfigurationVO configurationVO = _configDao.findByName(resourceDetail.getName());
ConfigurationVO configurationVO = configDao.findByName(resourceDetail.getName());
if (configurationVO != null && configurationVO.isEncrypted()) {
return DBEncryptionUtil.decrypt(resourceDetail.getValue());
}
Expand Down