CLOUDSTACK-9005: Modifying tearDown function#1000
Merged
asfgit merged 1 commit intoJan 17, 2016
Merged
Conversation
|
Sanjeev N on dev@cloudstack.apache.org replies: |
Contributor
|
LGTM Based on code understanding One line change if attribute is there then proceed to cleanup if hasattr(self, "data_volume_created"): |
Contributor
|
2 lgtm but no test report, will execute |
Author
|
Test Result: Storage and Snapshot Limit ...Ran 1 test in 970.317s OK |
Member
|
LGTM |
|
@remibergsma can you please merge this in? thanks, Raja |
asfgit
pushed a commit
that referenced
this pull request
Jan 17, 2016
…tearDown-function CLOUDSTACK-9005: Modifying tearDown functionModifying tearDown function to check if data volume is in detached state before deleting the volume * pr/1000: CLOUDSTACK-9005: Modifying tearDown function Signed-off-by: Remi Bergsma <github@remi.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifying tearDown function to check if data volume is in detached state before deleting the volume