PYTHON-836: Added lock to query plan for speculative execution#873
Merged
Conversation
mambocab
reviewed
Dec 6, 2017
| self.query_plan = iter(self._load_balancer.make_query_plan(self.session.keyspace, self.query)) | ||
| # Make iterator thread safe when there can be a speculative delay since it could | ||
| # from different threads | ||
| if self._spec_execution_plan is ResponseFuture._spec_execution_plan: |
Contributor
There was a problem hiding this comment.
I don't follow this identity check -- so, we make it threadsafe in the case where the execution plan is the NoSpeculativeExecutionPlan?
My gut says you mean if self._spec_execution_plan is not ResponseFuture._spec_execution_plan. Even with that behavior, I want to bring up a couple cases:
- The user passes a new
NoSpeculativeExecutionPlanobject -- in this case, we take a performance hit for no good reason. Maybe we don't care about that though, since the user should really just passNone. - The user sets
ResponseFuture._spec_execution_planas a way to set a default. We also might not care about this, since it's an underscored attribute.
One thought is that we could get around that by checking isinstance(self._spec_execution_plan, NoSpeculativeExecutionPlan)?
Contributor
Author
There was a problem hiding this comment.
👍 you're right, good catch, I'll take you check, overall seems safer.
Contributor
|
Other than my little comment, which you can ignore if you don't think it's an issue, I'm +1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.