Added tests for PYTHON-839#850
Merged
Merged
Conversation
2ff5a2d to
75faa61
Compare
mambocab
reviewed
Nov 1, 2017
| def set_default_beta_flag_true(): | ||
| defaults = list(Cluster.__init__.__defaults__) | ||
| defaults = defaults[:-3] + [True] + defaults[-2:] | ||
| defaults = defaults[:-4] + [True] + defaults[-3:] |
Contributor
There was a problem hiding this comment.
We can future-proof this a little better with
defaults[:27] + [True] + defaults[28:]:
In [1]: from cassandra.cluster import Cluster
In [2]: defaults = list(Cluster.__init__.__defaults__)
In [3]: (defaults[:-4] + [True] + defaults[-3:]) == (defaults[:27] + [True] + defaults[28:])
Out[3]: True
mambocab
approved these changes
Nov 1, 2017
Contributor
mambocab
left a comment
There was a problem hiding this comment.
My comment is just a small improvement. No hurry for it; we can change it later. Feel free to merge as-is if you want 👍
75faa61 to
0f3b5be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.