Skip to content

Ensure asyncore dispatchers are closed on shutdown#779

Merged
aboudreault merged 1 commit into
masterfrom
python-767
Jun 7, 2017
Merged

Ensure asyncore dispatchers are closed on shutdown#779
aboudreault merged 1 commit into
masterfrom
python-767

Conversation

@aboudreault
Copy link
Copy Markdown
Contributor

No description provided.

@aboudreault aboudreault mentioned this pull request Jun 5, 2017
@aboudreault
Copy link
Copy Markdown
Contributor Author

changelog entry is missing, I will add it shortly

@mambocab
Copy link
Copy Markdown
Contributor

mambocab commented Jun 6, 2017

Unfortunately, I wasn't able to repro this locally, so I can't verify that the change fixes the issue. However, based on your description of the issue, I buy that this fixes it.

I was briefly concerned that this could cause a race where an in-flight request that could complete in theory would not return -- but, if we're closing connections, any such requests would already be doomed to fail, right?

If that's the case, I'm +1 if you add a short comment noting that the conn.close() loop will error any in-flight requests and allow the asyncore dispatchers to be cleaned up.

@aboudreault
Copy link
Copy Markdown
Contributor Author

Indeed, at this point, all requests are already doomed anyway.

@aboudreault aboudreault merged commit 8e67b91 into master Jun 7, 2017
@aboudreault aboudreault deleted the python-767 branch June 7, 2017 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants