Ensure asyncore dispatchers are closed on shutdown#779
Merged
Conversation
Closed
Contributor
Author
|
changelog entry is missing, I will add it shortly |
Contributor
|
Unfortunately, I wasn't able to repro this locally, so I can't verify that the change fixes the issue. However, based on your description of the issue, I buy that this fixes it. I was briefly concerned that this could cause a race where an in-flight request that could complete in theory would not return -- but, if we're closing connections, any such requests would already be doomed to fail, right? If that's the case, I'm +1 if you add a short comment noting that the |
Contributor
Author
|
Indeed, at this point, all requests are already doomed anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.