Timer race condition#685
Closed
Massi78 wants to merge 3 commits into
Closed
Conversation
|
Hi @Massi78, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. Sincerely, |
|
Thank you @Massi78 for signing the Contribution License Agreement. Cheers, |
Contributor
|
Thanks for the PR. This looks related to PYTHON-644, which we happen to be looking into presently. We are planning to get this in for the next release. |
Closed
Contributor
|
Thanks again for the PR. We took a slightly different approach in #690, so I'm going to close this. Please feel free to make another PR or file a JIRA if the changes there don't address your concerns. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the execute_async() method, it may happen either _set_final_result() or _set_final_exception() is called before the _start_timer() execution.
Since both _set_final_result() and _set_final_exception() are responsible for cancelling the timer contained in the ResponseFuture object, in the case above the started timer won't be cancelled until the timeout condition is triggered even if the result has been already returned