CLQEngine multiple sessions/keyspaces support#656
Conversation
|
|
||
| using = UsingDescriptor() | ||
|
|
||
| _get_connection = BaseModel._get_connection |
There was a problem hiding this comment.
this has to be verified... not sure it's safe
There was a problem hiding this comment.
Still looking into this? Seems like it should work...
There was a problem hiding this comment.
alright. I wasn't sure if the hybrid_method could be binded to the other class or something.
|
|
||
| Host = namedtuple('Host', ['name', 'port']) | ||
|
|
||
| cluster = None |
There was a problem hiding this comment.
I like the object oriented approach, but wondering if we should set these module attributes when the default connection is made, so we don't lose attributes that were not explicitly "private".
There was a problem hiding this comment.
I would suggest do it for 3.x, but remove in 4.0. So cluster will always point to the DEFAULT cluster object.
|
Addressed comments and added tests |
| """Format log message to add keyspace and connection context""" | ||
| connection_info = connection if connection else DEFAULT_CONNECTION | ||
| connection_info = connection | ||
| if not connection_info: |
There was a problem hiding this comment.
Could this be simplified to connection_info = connection or 'DEFAULT_CONNECTION'?
There was a problem hiding this comment.
oh, yeah. totally.
|
+1 |
No description provided.