Conversation
Contributor
There was a problem hiding this comment.
What the thinking behind having the variables: ring_len and ring_len_range? They seem to be used once. Could the line they're used on be simplified to?
for i in range(len(ring)):
pass
Contributor
Author
There was a problem hiding this comment.
I guessed it was vestigial from an earlier implementation of the algorithm. I can change. I thought I did (as I also noticed it), but must have backed it out in my own rework.
peer review PYHTON-378
aholmberg
added a commit
that referenced
this pull request
Nov 12, 2015
PYTHON-378 - make NetworkTopologyStrategy consider rack placement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.