Conversation
Makes defuncting more efficient when there are many concurrent requests. Also corrects signalling semantics - only accrue one connection error per instance (not one per requests * instance).
PYTHON-367 Prevents unnecessary expansion of the timer heap during full outage, preventing resource explosion for pathological applications.
Prevents the event loop thread from being tied up too long when there are many concurrent requests on a broken connection.
Contributor
There was a problem hiding this comment.
Seems like a lot of the same code as in HostConnection does it make sense to merge any of this into a Connection method?
Contributor
Author
There was a problem hiding this comment.
Yeah. That's unfortunate. I put this flagging and logic at the pool level to avoid Connection having to know about Cluster and pooling logic. They are not quite the same because of the difference around replacing connections.
aholmberg
added a commit
that referenced
this pull request
Aug 13, 2015
PYTHON-367 - Mitigate timeouts and resource expansion during full cluster outage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.