Skip to content

PYTHON-108 - Timers#298

Merged
aholmberg merged 26 commits into
masterfrom
PYTHON-108
May 13, 2015
Merged

PYTHON-108 - Timers#298
aholmberg merged 26 commits into
masterfrom
PYTHON-108

Conversation

@aholmberg
Copy link
Copy Markdown
Contributor

@aholmberg aholmberg commented May 6, 2015

Full request timers

aholmberg added 18 commits April 30, 2015 10:42
@aholmberg
Basic timer management, and timer impl for Asyncore
d3d6020
@aholmberg
Timer for libevreactor
4a9e08e
@aholmberg
Update ResponseFutures to use reactor timers
109d6bb 
PYTHON-108
avoids sleep in Event.wait, which contributes to latency
when using synchronous execution
@aholmberg
Refactor redundant register_watcher[s] to Connection
6ea1504
@aholmberg
Gevent timer implementation
4d65357
@aholmberg
Catch and log exceptions during timeout servicing
e3fdffb
@aholmberg
refactor connected_event to Connection init
8702813
@aholmberg
Eventlet timer using eventlet.event.NOT_USED.
3489813 
This works with the current implementation, but there is no guarantee
about the stability of this mechanism in eventlet events. Probably need
to synchronize Event management.
@aholmberg
Use threading.Event for eventlet timeouts
c44365c 
Removes Eventlet Events, which are more difficult to use
@aholmberg
Twisted timer implementation
afe2e5a
@aholmberg
self-->cls in create_timer classmethods
7f5e9df
@aholmberg
Refactor _callbacks and _push_watchers init to Connection
67e19aa
@aholmberg
Allow ResponseFutures without a timeout
d7c68f9
@aholmberg
Remove deprecated, unused import from cqlengine getting started
4b2f046
@aholmberg
Allow canceled timers to finish ahead of end time.
60f59ce
@aholmberg
libev: service timeouts before updating loop timer.
c17e6e4 
Also, never start a timer with zero repeat (this causes it to stop,
rather than timeout immediately).
@aholmberg
Deprecate ResponseFuture.result timeout
9d8c50b
@aholmberg
Remove unused 'timeout' in ..cluster.PagedResult
70478e6
thobbs
thobbs reviewed May 7, 2015
View reviewed changes
Comment thread cassandra/cluster.py Outdated
Copy link
Copy Markdown
Contributor

@thobbs thobbs May 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OperationTimedOut() should be populated with _errors and _current_host, I think.

@thobbs
Copy link
Copy Markdown
Contributor

thobbs commented May 7, 2015

Since this fixes calling of callbacks/errbacks on timeout, the ResponseFuture docs need to be updated.

@aholmberg
Copy link
Copy Markdown
Contributor Author

aholmberg commented May 11, 2015

I believe all comments have been addressed. Pending reviewer concurrence.

aholmberg added a commit that referenced this pull request May 13, 2015
@aholmberg
Merge pull request #298 from datastax/PYTHON-108
f879700 
PYTHON-108 - Timers
@aholmberg aholmberg merged commit f879700 into master May 13, 2015
@aholmberg aholmberg deleted the PYTHON-108 branch May 13, 2015 21:33
@aholmberg aholmberg restored the PYTHON-108 branch May 15, 2015 19:41
aholmberg added a commit that referenced this pull request May 15, 2015
@aholmberg
Revert "Merge pull request #298 from datastax/PYTHON-108"
dfa91b8 
Taking out timers in the interest of accelerating C* 2.2 features for a
release.

This reverts commit f879700, reversing
changes made to fe4d2ea.
mike-tr-adamson pushed a commit to mike-tr-adamson/python-driver that referenced this pull request Jun 16, 2015
@rustyrazorblade
Merge pull request apache#298 from anthonyyim/ay_typo_fix
3b81177 
Fixes typo in docstring.
aholmberg added a commit that referenced this pull request Jun 19, 2015
@aholmberg
Revert "Revert "Merge pull request #298 from datastax/PYTHON-108""
ee2243c 
This reverts commit dfa91b8.

Conflicts:
	cassandra/cluster.py
	cassandra/connection.py
	cassandra/io/asyncorereactor.py
	cassandra/io/eventletreactor.py
	cassandra/io/geventreactor.py
	cassandra/io/libevreactor.py
	cassandra/io/twistedreactor.py
	cassandra/query.py
@aholmberg aholmberg deleted the PYTHON-108 branch September 9, 2015 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aholmberg @thobbs