Skip to content

CASSANDRA-7814: Added indexes to table and ks metadata #263

Merged
aholmberg merged 2 commits into
apache:masterfrom
stef1927:7814-indexes-optim
Apr 22, 2015
Merged

CASSANDRA-7814: Added indexes to table and ks metadata #263
aholmberg merged 2 commits into
apache:masterfrom
stef1927:7814-indexes-optim

Conversation

@stef1927

@stef1927 stef1927 commented Apr 1, 2015

Copy link
Copy Markdown

This is the suggested change for https://datastax-oss.atlassian.net/browse/PYTHON-241.

@datastax-bot

datastax-bot commented Apr 1, 2015

Copy link
Copy Markdown

Hi @stef1927, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

Sincerely,
DataStax Bot.

@datastax-bot

datastax-bot commented Apr 1, 2015

Copy link
Copy Markdown

You did it @stef1927!

Thank you for signing the Contribution License Agreement.

Cheers,
DataStax Bot.

aholmberg
aholmberg reviewed Apr 20, 2015
View reviewed changes
Comment thread cassandra/metadata.py Outdated

@aholmberg aholmberg Apr 20, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if this functionality would be better implemented in KeyspaceMetadata, where the index is held (KeyspaceMetadata.add_table(self, table_meta), or something like that).

@stef1927 stef1927 Apr 21, 2015

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you are quite right, I moved both methods to the ks metadata, see latest commit.

@aholmberg aholmberg mentioned this pull request Apr 21, 2015
Merged
@aholmberg

aholmberg commented Apr 21, 2015

Copy link
Copy Markdown
Contributor

Please see updates in #284. Let me know what you think of those changes.

@stef1927

stef1927 commented Apr 22, 2015

Copy link
Copy Markdown
Author

Changes look good and tests for CASSANDRA-7814 still pass, thanks!

@aholmberg
aholmberg merged commit 7b15fae into apache:master Apr 22, 2015
carlyeks pushed a commit to carlyeks/python-driver that referenced this pull request Apr 27, 2015
@rustyrazorblade
Merge pull request apache#263 from mission-liao/faq_statement_ordering
488a75b 
add note on statement ordering in batch query
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stef1927 @datastax-bot @aholmberg