PYTHON-163 - Don't try to connect to peers with incomplete meta#218
Merged
Conversation
Contributor
There was a problem hiding this comment.
It seems like it would be better to move the conditional/continue here. With the current code, it will call cluster.add_host() only to remove it shortly after when the old and new hosts are diffed.
peer review input
aholmberg
added a commit
that referenced
this pull request
Dec 4, 2014
PYTHON-163 - Don't try to connect to peers with incomplete meta
aholmberg
pushed a commit
that referenced
this pull request
Mar 18, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
possible solution. Please see JIRA ticket for further discussion.