Test 68#1066
Merged
Merged
Conversation
- Materialized view tests: You now can't create a MV with clustering order by unless you specify ALL of the clustering columns. So tests are updated to do that. - DuplicateRpcTest: We used to be able to update system.peers, but that's not allowed anymore, so converted it to a simulacron test.
…t will change between versions. Rather, verify a few known values that should exist in all versions to verify we parsed the structure correctly.
… intead of just cells in tombstone tests due to DB-2426.
aboudreault
reviewed
Jan 23, 2020
| from cassandra.cluster import Cluster, ControlConnection | ||
|
|
||
|
|
||
| PROTOCOL_VERSION = min(4, PROTOCOL_VERSION if (DSE_VERSION is None or DSE_VERSION >= Version('5.0')) else 3) |
Contributor
There was a problem hiding this comment.
this is only a default value?
Contributor
Author
There was a problem hiding this comment.
Stole it from another simulacron test after getting protocol errors. Looks like simulacron barfs when we try to pass a higher protocol version.
aboudreault
approved these changes
Jan 23, 2020
avikivity
added a commit
to scylladb/python-driver
that referenced
this pull request
Jan 27, 2020
* 'master' of https://github.com/datastax/python-driver: (286 commits) Test 68 (apache#1066) Add all() function to the ResultSet API Changes from test failures. ninja fix invalid syntax in test remove test code Moved some utils module to fix import errors in unit tests release 3.21: update docs Last fix for the registered char for Cassandra release 3.21: docs use ® for docs summary release 3.21: docs use TM for docs summary, not the registered char release 3.21: docs release 3.21: changelog A few other docs fixes Minor documentation improvements update 3.21 hash in docs.yaml docs.yaml should install deps from test-datastax-requirements.txt add 3.21 in docs.yaml release 3.21: bump version ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major changes mentioned in commits but summarized here:
I'll squash down to one commit when merging