Fix eclipse problems#954
Merged
Merged
Conversation
tolbertam
approved these changes
Feb 20, 2018
Contributor
tolbertam
left a comment
There was a problem hiding this comment.
Looks good to me. Since changes are isolated to org.eclipse.m2e:lifecycle-mapping it is a low risk change 👍
olim7t
approved these changes
Feb 20, 2018
Contributor
olim7t
left a comment
There was a problem hiding this comment.
👍 since the m2eclipse configuration was already present, but on a side note I'm not a big fan of polluting the POM with IDE-specific configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were 2 problems with importing Java driver into Eclipse:
groupIdspecified, so m2e plugin couldn't import the project correctly