Allow Guava 21 to be imported in OSGi bundle#821
Merged
Merged
Conversation
adutra
requested changes
Mar 3, 2017
| Explicitly import javax.security.cert because it's required by Netty, but Netty has been explicitly excluded | ||
| --> | ||
| <![CDATA[com.google.common.*;version="[16.0.1,21)",!jnr.*,!io.netty.*,javax.security.cert,*]]></Import-Package> | ||
| <![CDATA[com.google.common.*;version="[16.0.1,22)",!jnr.*,!io.netty.*,javax.security.cert,*]]></Import-Package> |
Contributor
There was a problem hiding this comment.
I see that sometimes we use com.google.common.* and sometimes com.google.common*. Both seem to work but for consistency I'd suggest using one or the other. (Disclaimer: I might be the culprit here.)
Contributor
Author
There was a problem hiding this comment.
👍 on making it consistent, didn't even notice that, which would you prefer? I like com.google.common.* i think.
adutra
approved these changes
Mar 6, 2017
Contributor
Author
|
Rebased on 3.x and squashed commits, should be ready to go. |
Also consistently use com.google.common.* for Import-Package
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While implementing JAVA-1328, Guava 21.0 was released. We accounted for it everywhere except in our OSGi bundle definition, this PR addresses this. Also added a test.