Conversation
olim7t
approved these changes
Feb 15, 2017
Contributor
|
As an aside, the "Allow edits from maintainers" checkbox is checked by default when external users create a pull request, we should be able to push to their branch instead of opening another PR. |
Separate the built-in codecs so that they can be backed by a static EnumMap instead of Guava Cache.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opened this PR to explore another idea to improve
CodecRegistryperformance: use anEnumMapinstead of Guava'sImmutableMap.Here are my benchmark results:
Benchmark code here.
Note:
benchmarkCqlTypeValueandbenchmarkValueare a bit biased in my implementation because they test the best-case scenario (the codec to find is the first in the array).