Various test fixes for 3.2.0#791
Merged
Merged
Conversation
33d29c7 to
2f46616
Compare
2f46616 to
3e89525
Compare
tolbertam
reviewed
Jan 25, 2017
|
|
||
| private static boolean isThriftSupported(boolean dse, VersionNumber version) { | ||
| return | ||
| (!dse && version.compareTo(VersionNumber.parse("3.10")) < 0) |
Contributor
There was a problem hiding this comment.
I think C* 4.0 will be the first version without thrift. It will still be present in 3.10, but not in trunk.
tolbertam
suggested changes
Jan 25, 2017
Contributor
tolbertam
left a comment
There was a problem hiding this comment.
Other than my comment about C* and Thrift, this looks good to me 👍
3e89525 to
650ad2d
Compare
tolbertam
reviewed
Jan 26, 2017
| } | ||
|
|
||
| private static boolean isThriftSupported(boolean dse, VersionNumber version) { | ||
| return dse || version.compareTo(VersionNumber.parse("4.0")) < 0; |
Contributor
There was a problem hiding this comment.
Just curious, but what is the significance of DSE here? Although all versions of DSE support Thrift at the moment, i imagine that will change too. That being said I think it is fine this way for now.
Contributor
Author
There was a problem hiding this comment.
I'm just assuming that all versions of DSE support thrift for now, because I don't know when C* 4.0 will get pulled in DSE.
Contributor
💯 for using a string for the version. |
Motivation: Many tests are failing when using recent versions of C* or DSE. Modifications: 1) Bump the default C* version to 3.8 2) Redesign @CassandraVersion and @DseVersion to be able to fully accept tick-tock releases and correctly compare them. 3) Reduce log verbosity for Scassandra tests 4) Prevent thrift from being enabled for C* >= 4.0 5) Fix decommission tests with C* >= 3.12 This commit contains contributions by Andrew Tolbert (@tolbertam). Result: All tests should pass.
650ad2d to
eda8314
Compare
tolbertam
pushed a commit
that referenced
this pull request
Feb 13, 2017
Motivation: Many tests are failing when using recent versions of C* or DSE. Modifications: 1) Bump the default C* version to 3.8 2) Redesign @CassandraVersion and @DseVersion to be able to fully accept tick-tock releases and correctly compare them. 3) Reduce log verbosity for Scassandra tests 4) Prevent thrift from being enabled for C* >= 4.0 5) Fix decommission tests with C* >= 3.12 This commit contains contributions by Andrew Tolbert (@tolbertam). Result: All tests should pass.
tolbertam
pushed a commit
that referenced
this pull request
Feb 13, 2017
Motivation: Many tests are failing when using recent versions of C* or DSE. Modifications: 1) Bump the default C* version to 3.8 2) Redesign @CassandraVersion and @DseVersion to be able to fully accept tick-tock releases and correctly compare them. 3) Reduce log verbosity for Scassandra tests 4) Prevent thrift from being enabled for C* >= 4.0 5) Fix decommission tests with C* >= 3.12 This commit contains contributions by Andrew Tolbert (@tolbertam). Result: All tests should pass.
tolbertam
added a commit
that referenced
this pull request
Feb 17, 2017
Backport #791 and remove ambiguity in Cassandra and DSE versions in tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Many tests are failing when using recent versions of C* or DSE.
Modifications:
tick-tock releases and correctly compare them.
This commit contains contributions by Andrew Tolbert (@tolbertam).
Result:
All tests should pass.