Conversation
adutra
previously approved these changes
Feb 9, 2017
adutra
requested changes
Feb 9, 2017
| - [bug] JAVA-1351: Include Custom Payload in Request.copy. | ||
| - [bug] JAVA-1346: Reset heartbeat only on client reads (not writes). | ||
| - [improvement] JAVA-866: Support tuple notation in QueryBuilder.eq/in. | ||
| - [improvement] JAVA-1357: Document that getReplicas only returns replicas of the last token in range. |
Contributor
There was a problem hiding this comment.
This should now be placed under 3.0.7.
adutra
approved these changes
Feb 9, 2017
Contributor
|
Went ahead and did the change myself. 👍 |
Motivation: Metadata.getReplicas(String, TokenRange) currently assumes that the TokenRange provided represents a TokenRange for a single host. Because of this, it finds the replicas for the last Token on that range instead of considering the entire range. Document that this is the case. Modifications: Updated method javadoc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For JAVA-1357
Motivation:
Metadata.getReplicas(String, TokenRange) currently assumes that the
TokenRange provided represents a TokenRange for a single host. Because
of this, it finds the replicas for the last Token on that range instead
of considering the entire range. Document that this is the case.
Modifications:
Updated method javadoc.