Conversation
|
|
||
| ThreadFactory threadFactory(String name) { | ||
| return new ThreadFactoryBuilder().setNameFormat(clusterName + "-" + name + "-%d").build(); | ||
| return new ThreadFactoryBuilder() |
Contributor
There was a problem hiding this comment.
Couldn't we use:
return new DefaultThreadFactory(clusterName + "-" + name);Although I noticed that this gives a slightly different name, i.e.: cluster1-nio-worker-7-1 instead of cluster1-nio-worker-1 since it seems to assign a unique pool id to each thread factory, so maybe the way it is done here is best for compatibility with the existing naming (also that unique id seems extraneous since we're sort of doing that ourselves with the cluster name).
Contributor
Author
There was a problem hiding this comment.
Yes, keeping the exact same naming was my motivation here.
This makes all of our threads instances of Netty's FastThreadLocalThread, which allows an optimization of ThreadLocal variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes all of our threads instances of Netty's
FastThreadLocalThread, which allows an optimization of ThreadLocal
variables.