Disable default TestNG listeners#730
Merged
Merged
Conversation
TestNG old HTML reporter generates a lot of File I/O since it open/closes files repeatedly which can cause system instability like OS crashes rarely. This is made worse compounded by that each test class file is considered its own suite, which causes an amplification of file open and closes. Since we only use the target/surefire-reports/TEST-TestSuite.xml file, disabling these listeners shouldn't cause any problems.
14895d1 to
b16beff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestNG old HTML reporter generates a lot of File I/O since it
open/closes files repeatedly which can cause system instability
like OS crashes rarely. This is made worse compounded by that
each test class file is considered its own suite, which causes an
amplification of file open and closes.
Since we only use the target/surefire-reports/TEST-TestSuite.xml
file, disabling these listeners shouldn't cause any problems.
Found via profiling that during this time the reporter is opening and closing upwards of 12k files per second:
Looking at file probes, it appeared to be opening and closing the same files over and over again in the target/surefire-reports/old directory.