Conversation
af2db15 to
2a528f8
Compare
|
|
||
| Therefore it is currently recommended to not create prepared statements | ||
| for 'select *' queries unless you don't plan on making schema changes involving | ||
| adding or dropping columns. Alternatively you should list all columns of interest |
Contributor
There was a problem hiding this comment.
I would replace "unless you don't plan" with "if you plan" (the double negative is harder to read).
Contributor
Author
There was a problem hiding this comment.
I don't think I should not fix this :P (fixing shortly)
Contributor
Author
There was a problem hiding this comment.
Fixed in 609f3a2, can be squashed before merge.
Contributor
|
👍 |
| ``` | ||
|
|
||
|
|
||
| ### Why do my 'select *' `PreparedStatement`-based queries stop working after a schema change? |
Contributor
There was a problem hiding this comment.
I see that we tend to use upper case letters for CQL keywords throughout the manual, so for consistency I suggest changing 'select *' to SELECT *.
Contributor
Author
There was a problem hiding this comment.
Always good to be consistent, will fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For JAVA-1227.
Added section to 'Prepared Statements' doc and FAQ. The first paragraph is the same in each section, with the FAQ entry linking to the doc.
Assigned to 3.0.3 milestone as the jira ticket targets this.