Conversation
| } | ||
|
|
||
| private void logIdempotenceWarning() { | ||
| if (WARNED_IDEMPOTENT.compareAndSet(false, true)) |
There was a problem hiding this comment.
What do you think about establishing a common logger implementation for messages like this? This way users can easily suppress warnings like this globally for all changes. Some users pay very close attention to warnings and try their best to suppress all the ones that doesn't affect their application health.
|
A bunch of tests look to have been broken with this, but I think it should be pretty easy to fix. Tests need to either be updated to mark certain statements as idempotent, or update their expected exceptions to account for the fact that they won't be retried, i'll take care of that. EDIT: Fixed |
| /** | ||
| * Base class for retry policy integration tests. | ||
| * <p/> | ||
| * <p> |
There was a problem hiding this comment.
ack, my bad, my environment is targeting JDK 8 which uses <p> instead of <p/> will fix.
This was opt-in behavior in 3.0.0, make it the default because it's the right thing to do. The counterpart is that the isIdempotent flag needs to be positioned properly on statements, the doc has been updated in that regard. This was made as an "internal" change (as opposed to a retry policy implementation), so that it would work with any retry policy. Therefore `IdempotenceAwareRetryPolicy` becomes redundant and was deprecated.
These methods always return the same result. Extract constants to avoid building a new object each time (even though the JVM probably optimized it eventually).
No description provided.