Conversation
| * results as soon as there is less than 100 rows readily available in this | ||
| * result set, you can do: | ||
| * <pre> | ||
| * ResultSet rs = session.execute(...); |
There was a problem hiding this comment.
The javadocs still mention ResultSet in some places but I guess it's ok since ResultSet is the only child interface of this one in this module.
|
Squashed and rebased on top of current 3.0. Note that I also renamed |
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object other) { |
There was a problem hiding this comment.
Minor remark: strictly speaking you don't need to implement equals and hashCode here, since you're accumulating the ids below.
|
Rebased and addressed feedback. Does everyone agree that |
|
|
||
| // redeclared only to make clirr happy | ||
| @Override | ||
| Row one(); |
There was a problem hiding this comment.
Since this is going into 3.1.0, does it matter that clirr isn't compliant for this particular case?
There was a problem hiding this comment.
You mean, you would prefer that I add the exception to clirr-ignores.xml? the exact error is
7002: com.datastax.driver.core.ResultSet: Method 'public com.datastax.driver.core.Row one()' has been removed
Sounds good to me, I like that you don't really lose anything mapping from |
|
|
||
| @BeforeMethod(groups = "short") | ||
| public void cleanup() { | ||
| session().execute("TRUNCATE users"); |
There was a problem hiding this comment.
I worry that truncate can be somewhat/slow unreliable, but it should not remotely be a problem with a smaller set of data, so not worried in this case.
This commit also extracts a common super-interface for both ResultSet and Result, called PagingIterable.
This commit also extracts a common super-interface for both
ResultSetandResult, as suggested by the ticket reporter. Clirr plugin was happy with that so I went ahead and implemented the idea.