Conversation
|
Rebased on 3.0.x (only conflict was README.md), to get other jdk6 fix changes to see if it fixes remaining problems. |
| <version>1.0</version> | ||
| </signature> | ||
| </configuration> | ||
| <executions> |
There was a problem hiding this comment.
Took me a little bit to wrap my head around this, but this is very cool. The annotation solution is pretty elegant. It would be even nicer if animal-sniffer supported package level annotations (i.e. if a package is annotated, it skips all of its classes), but it doesn't look like that currently works (but maybe a nice change request for animal sniffer).
|
This looks good to me and is running well in CI 👍 |
|
I should note that the OSGi tests aren't running on this branch, but i think that is a carry over from 2.1 as it doesn't appear to be running it either :(. It looks like #635 fixes this, so that will take care of that. |
|
I went ahead and rebased this since the only conflict was README.md. |
The animal-sniffer plugin is now configured to run twice: once against JDK6 (excluding classes in jdk8 package), then against JDK8 (nothing excluded).
IntelliJ can report inadequate usage of API call, which is very useful in normal situations, but enabling this warning would mark the whole jdk8 package with errors. This commit disables the errors for classes in this package, but to achieve this, no imports could be used, and offending classes must appear with fully-qualified class names everywhere.
No description provided.