Conversation
Contributor
Author
There was a problem hiding this comment.
Small enhancement backported from 3.0: this line would throw an OutOfBoundsException for the empty string.
70d47c1 to
acfdd5b
Compare
Contributor
Author
There was a problem hiding this comment.
for a better spacing when outputting columns in non-formatted mode.
| * @test_category metadata | ||
| */ | ||
| @Test(groups = "short") | ||
| public void should_parse_table_with_case_sensitive_column_names_and_reserved_keywords() throws Exception { |
Contributor
|
Looks good 👍 |
| static final String STATEMENT_START = "\n\t"; | ||
| static final String COLUMN_FORMATTING = "\n\t\t"; | ||
|
|
||
| static final List<String> RESERVED_KEYWORDS = Arrays.asList( |
Contributor
Author
There was a problem hiding this comment.
replaced with the equivalent in Metadata.
added 4 commits
March 3, 2016 10:36
…emaStatement.validateNotKeyword().
olim7t
added a commit
that referenced
this pull request
Mar 3, 2016
JAVA-1064: getTable create statement doesn't properly handle quotes in primary key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixes reserved keywords.