Conversation
Contributor
|
👍 Very elegant solution to get a proper error message for collections of unknown elements. |
Contributor
There was a problem hiding this comment.
Would be good to use @throws annotation here since this is an unchecked exception.
Contributor
Author
There was a problem hiding this comment.
That's a regular comment though, not a javadoc (the method is package-private).
Contributor
There was a problem hiding this comment.
ah didn't notice that, in that case it definitely isn't needed then :)
olim7t
added a commit
that referenced
this pull request
Feb 23, 2016
JAVA-833: Improve message when a nested type can't be serialized.
Sfurti-yb
pushed a commit
to yugabyte/cassandra-java-driver
that referenced
this pull request
Dec 8, 2023
[resolves apache#555]
Sfurti-yb
pushed a commit
to yugabyte/cassandra-java-driver
that referenced
this pull request
Dec 8, 2023
[apache#555] Signed-off-by: Mark Paluch <mpaluch@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throw an exception instead of propagating null back. I also changed the base message to avoid repeating the same thing twice when the wrong type is the root type.
This does not need to be merged in 3.0.