Conversation
Contributor
|
Rebased on current 2.1 and added patch from @snazy for JAVA-664.
|
Contributor
There was a problem hiding this comment.
We can't memoize replicas based on primaryHost. What determines the contents of replicas is the section of the ring after token i; but multiple tokens can be assigned to the same host, so for different start positions you might get the same primaryHost, but what you encounter next on the ring will not be the same. That's why the tests fail.
Contributor
|
👍 |
Contributor
Author
|
big 👍 on the JAVA-664 change |
olim7t
added a commit
that referenced
this pull request
Dec 2, 2015
JAVA-989: Include keyspace name when invalid replication found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For JAVA-989. Now logs the following when invalid replication is found on a keyspace:
The one thing i'm not so sure of here is passing the keyspace name into
computeTokenToReplicaMap. It is only used for logging, so seems somewhat extraneous, but since this is an internal API maybe this is not too much of a problem.