Add isolated test group and profile for tests requiring their own JVM.#515
Conversation
|
Waiting to see if this works well in CI before removing wip tag. |
d8a7802 to
0724eaf
Compare
There was a problem hiding this comment.
The only reasons I have 'failIfNoTests' and 'maven.test.failure.ignore' present here is so the build can continue and run other tests. For example, if the 'driver-core' build fails tests, the artifacts aren't created and thus integration tests fail. We'd normally not want to use these flags for build/releases but for the intent of CI testing it works.
|
This seems to be working good, think it's good to go unless any reservations on the approach. |
There was a problem hiding this comment.
I think it is recommended to invoke the verify phase instead, like in clean verify --fail-never -Plong
There was a problem hiding this comment.
Cool, so that'd run both test and integration-test phase (as well as any other checks?). I'll give that a try, thanks!
|
👍 |
This is useful for tests that touch static members or require a 'clean' environment. Applied to SSL tests that rely on SSLContext.getDefault which depends on System properties and is only ever loaded once. Also configure failure parameters such that OSGi integration tests may run despite any test failures.
ac5df93 to
cd3592c
Compare
|
Looks like verify works great, thanks for the tip :). I think this is now good to go. |
Add isolated test group and profile for tests requiring their own JVM.
Also, improve PostgresTypes safety if the collection of type names is empty. [resolves apache#515] Signed-off-by: Mark Paluch <mpaluch@vmware.com>
This is useful for tests that touch static members or require a 'clean' environment.
Applied to currently failing SSL tests that rely on SSLContext.getDefault which depends on System properties and is only ever loaded once.
Also configure failure parameters such that OSGi integration tests may run despite any test failures.