Integration Test Grooming#513
Merged
Merged
Conversation
ClusterInitTest#should_handle_failing_or_missing_contact_points previously checked to see if hosts were marked down, but its not guaranteed that all expected hosts are marked down at this time as onDown is submitted in an executor and may not have been processed/finished.
71785d6 to
94d869c
Compare
Contributor
Author
|
Removing [wip] tag from this. A few of the recent fixes were required to accommodate recent changes targeted for 2.0.12 and all the other changes seem to have positive impact. Would be nice to get this merged in ahead of the release. |
b11ec0a to
cf14782
Compare
Cluster.Manager.preparedQueries is a weak value map so as PreparedStatement instances become dereferenced from client code the garbage collector may collect these instances and thus remove elements from the map.
The intent of this test is to ensure that there is not a Deadlock on Cluster.close(). The time taken to close can be affected by local system performance. Since CI runs on somewhat constrained systems increasing the timeout to 5 seconds seems reasonable.
This test was failing as it only waits up to 1 second for a cluster to close. This can at last 2 seconds with the changes for JAVA-914 unless you override the default behavior in NettyOptions#onClusterClose.
cf14782 to
d2d1f0e
Compare
Sfurti-yb
pushed a commit
to yugabyte/cassandra-java-driver
that referenced
this pull request
Dec 8, 2023
Sfurti-yb
pushed a commit
to yugabyte/cassandra-java-driver
that referenced
this pull request
Dec 8, 2023
… syntax
- Lexing/parsing is now done in two steps: first only tokenize, then parse into statements
- Added support for function bodies ("BEGIN ATOMIC")
- Added a test case for newly supported grammar
[resolves apache#512][apache#513]
Sfurti-yb
pushed a commit
to yugabyte/cassandra-java-driver
that referenced
this pull request
Dec 8, 2023
Reorder methods. Use CharObjectMap for operator character lookup instead of linear array iteration. Extract peek/has next token functionality into dedicated methods. Migrate assertions to AssertJ. Add benchmark. [apache#512][resolves apache#513] Signed-off-by: Mark Paluch <mpaluch@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses some inconsistently passing tests on the 2.0 branch. There are a few more than need addressing (primary in RecommissionedNodeTest).