Conversation
Contributor
There was a problem hiding this comment.
Nitpicking: the getter of a primitive boolean property should start with "is": isPrepareStatementsOnce() sounds better here (with defaultIdempotence, I'd say we have an exception to this rule in that the property itself is not true or false, it simply tells if the default value for idempotence should be true or false).
Contributor
|
It would be clearer if the property was inverted and called "prepareOnAllHosts". |
Contributor
Author
|
PR updated after processing comments. |
Also primes a query for retrieving peer by peer ip.
olim7t
added a commit
that referenced
this pull request
Aug 9, 2015
JAVA-797 : Added option to prepare statements once
Contributor
|
Merged. |
Sfurti-yb
pushed a commit
to yugabyte/cassandra-java-driver
that referenced
this pull request
Dec 8, 2023
The problem: when our receive buffer fills and conversation demand drops to zero and last item is `CommandComplete` we never request more frames and will never get `ReadyForQuery` Signed-off-by: Mark Paluch <mpaluch@vmware.com> [closes apache#401][apache#426]
Sfurti-yb
pushed a commit
to yugabyte/cassandra-java-driver
that referenced
this pull request
Dec 8, 2023
Remove windowUntil(…) to avoid miscalculation of demand in long-running streams. Refine discardOnCancel operator calls to properly guard simple queries. [apache#401][apache#426] Signed-off-by: Mark Paluch <mpaluch@vmware.com>
Sfurti-yb
pushed a commit
to yugabyte/cassandra-java-driver
that referenced
this pull request
Dec 8, 2023
[apache#401][apache#426] Signed-off-by: Mark Paluch <mpaluch@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Writing a test for this option would need either adding a feature in SCassandra to be able to retrieve prepared statements in ActivityClients, because right now it only takes in accounts executed prepared statements. Or, having a ticket like CASSANDRA-8831 implemented in Cassandra.