Skip to content

JAVA-688 : QueryBuilder doesn't serialize raw strings#358

Merged
adutra merged 1 commit into
2.1from
java688
Jun 11, 2015
Merged

JAVA-688 : QueryBuilder doesn't serialize raw strings#358
adutra merged 1 commit into
2.1from
java688

Conversation

@newkek
Copy link
Copy Markdown
Contributor

@newkek newkek commented May 28, 2015

No description provided.

@olim7t
Copy link
Copy Markdown
Contributor

olim7t commented Jun 4, 2015

LGTM. Could you add a unit test in QueryBuilderTest?

To be clear, the goal is to ensure that the QUERY message generated is a raw string, with no parameters. Another way of checking it is that statement.getQueryString() should not contain placeholders.

The example I put in the ticket is a bit contrived, but that should do if the test explains it.

@newkek
Copy link
Copy Markdown
Contributor Author

newkek commented Jun 8, 2015

I put both test for QUERY and placeholders, and for getValues(), so we are sure.

@newkek newkek self-assigned this Jun 8, 2015
adutra added a commit that referenced this pull request Jun 11, 2015
JAVA-688 : QueryBuilder doesn't serialize raw strings
@adutra adutra merged commit 2e811de into 2.1 Jun 11, 2015
@adutra adutra deleted the java688 branch June 11, 2015 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants