New addContactPoints method for resolving multiple InetAddress from one hostname#340
Merged
Conversation
…ss but all that is returned from the host lookup. This will greatly simplify setups as we can add a single cassandra_seeds dns record and have that statically added to our configuration.
Contributor
|
I agree that this should eventually be the default, but I don't want to introduce it in a minor version to avoid errors if someone has a broken DNS configuration. We have a ticket where we track the stuff we want to make the default in the next major version (JAVA-616), I've added this to the list. |
Contributor
|
I cherry-picked your commit to make this the default in 2.2 (#360). I will merge this PR to the older branches. |
Author
|
👍 |
olim7t
added a commit
that referenced
this pull request
Jun 17, 2015
New addContactPoints method for resolving multiple InetAddress from one hostname
Sfurti-yb
pushed a commit
to yugabyte/cassandra-java-driver
that referenced
this pull request
Dec 8, 2023
Prepare code compatibility for newer Java versions that introduced overrides for ByteBuffer.flip() returning ByteBuffer instead of Buffer. [closes apache#340]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will make the cluster not only use the first available InetAddress but all that is returned from the host lookup.
This will greatly simplify setups as we can add a single cassandra_seeds dns record and have that statically added to our configuration.
As suggested by @olim7t I added this feature as a new method, keeping the symmetry with other addContactPoint(s) methods.
Imo this should go in to the main addContactPoint method, as it should be transparent if the host points to one or many InetAddresses. But that is in the end the decision of you guys.