Skip to content

removed jackson dependency, fixed invalid CQL order by syntax#31

Closed
briandilley wants to merge 2 commits into
apache:masterfrom
briandilley:master
Closed

removed jackson dependency, fixed invalid CQL order by syntax#31
briandilley wants to merge 2 commits into
apache:masterfrom
briandilley:master

Conversation

@briandilley
Copy link
Copy Markdown

Changed from an old version of jackson to json.org
Fixed order by statements for CQL select.

@ash2k
Copy link
Copy Markdown
Member

ash2k commented Jan 27, 2013

It's a bad idea to use org.json.

@briandilley
Copy link
Copy Markdown
Author

well, i could change it to use the latest version of Jackson. Jackson just seemed like overkill to me, but mainly it was using an older version.

pcmanus pushed a commit that referenced this pull request Jan 28, 2013
@pcmanus
Copy link
Copy Markdown

pcmanus commented Jan 28, 2013

I've fixed the query builder syntax, thanks for that.

As for the jackson 1.4 dependency, it is already pulled by cassandra-all anyway, so there's little point in changing it. We will try to minimize further the driver dependency in the future, but this will have to start by removing the dependency on cassandra-all which itself will require CASSANDRA-4623 first. As for Jackson, it's not used anywhere performance sensitive so I don't think it's worth bothering which version is used exactly.

As a side note, I'd suggest avoiding unrelated changes in the same pull request.

@pcmanus pcmanus closed this Jan 28, 2013
@briandilley
Copy link
Copy Markdown
Author

thanks.

i did a single pull request because github wouldn't let me create more than one :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants