Conversation
tomekl007
reviewed
Dec 30, 2019
| .appendListElement("l", literal(1)) | ||
| .whereColumn("k").isEqualTo(bindMarker()) | ||
| .build(); | ||
| // UPDATE foo SET l+=[1] WHERE k=? |
Contributor
There was a problem hiding this comment.
this change confuses me, I think that the goal of the ticket is to support += syntax, but here instead we are changing the syntax to value= value+...
Contributor
Author
There was a problem hiding this comment.
No the goal of the ticket is not to support x += y. This is the currently supported syntax, but it has the drawback of not being available for C* < 3.10. The goal is to use the old, alternative syntax x = x + y, which is more widely supported.
tomekl007
approved these changes
Dec 30, 2019
olim7t
approved these changes
Dec 31, 2019
| // UPDATE foo SET l=l-[myfunc()] WHERE k=? | ||
| assert !statement.isIdempotent(); | ||
| ``` | ||
|
|
Contributor
There was a problem hiding this comment.
👍 I had to refer to the javadocs to remember when terms weren't idempotent, so good thing to mention it in the manual too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm also proposing a fix for JAVA-2596 since it's entangled.