Skip to content

JAVA-2509: Mention file-based approach for Cloud configuration in the manual#1352

Merged
adutra merged 2 commits into
4.xfrom
java2509
Oct 23, 2019
Merged

JAVA-2509: Mention file-based approach for Cloud configuration in the manual#1352
adutra merged 2 commits into
4.xfrom
java2509

Conversation

@adutra

@adutra adutra commented Oct 22, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@adutra adutra added this to the 4.3.0 milestone Oct 22, 2019
@adutra adutra requested a review from emerkle826 October 22, 2019 11:35
Comment thread manual/cloud/README.md
```hocon
basic {
# change this to match the target keyspace
session-keyspace = keyspace_name

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it need to be specified? I think it will be taken from secure-connect-bundle

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't parse the keyspace anymore. We still parse the credentials though, even if they are now always absent.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but even in that case, the session-keyspace is not required, right?
The client can specify keyspace later. I am not sure if we should mention that in the docs

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about the keyspace actually. It was said at some point that users would have access to just one keyspace. Not sure if this is valid still. But it doesn't hurt to specify a keyspace anyways, so I would leave it that way. @emerkle826 do you know by chance if a keyspace is required for cloud?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last I was aware, you don't need to specify a keyspace, but I believe you are correct in that they will only have access to one keyspace (for now at least). From Jorge:

I think there was consensus for not parsing the keyspace: users might be able to create their own keyspace in future versions of cloud and it will not be provided when switching to token-based auth

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case let's leave the keyspace example, it seems that at least for the initial Cloud version it will be necessary to set it since users will only have access to that specific keyspace.

Comment thread manual/cloud/README.md Outdated
@adutra adutra merged commit 73a709e into 4.x Oct 23, 2019
@adutra adutra deleted the java2509 branch October 23, 2019 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants