Conversation
| * @param javaClass the Java class this codec maps to. | ||
| */ | ||
| public JacksonJsonCodec(Class<T> javaClass, ObjectMapper objectMapper) { | ||
| public JacksonJsonCodec(Class<T> javaClass, JsonMapper jsonMapper) { |
There was a problem hiding this comment.
I know this is a public method signature change, but it is in the examples project, so I figured it's not a big deal.
| <jax-rs.version>2.0.1</jax-rs.version> | ||
| <jsr353-ri.version>1.1.4</jsr353-ri.version> | ||
| <jackson.version>2.9.9</jackson.version> | ||
| <jackson-databind.version>2.9.9.3</jackson-databind.version> |
There was a problem hiding this comment.
It looks like this property is referenced specifically in com.datastax.oss.driver.osgi.BundleOptions::jacksonBundles()... is that a problem?
There was a problem hiding this comment.
good catch, I thought I caught all the references.
There was a problem hiding this comment.
Yes because versions for these two artifacts started diverging a while ago.
There was a problem hiding this comment.
I think it might be easier to just keep declaring these 2 properties, even if they have the same value.
|
Pushed a small fix for the databind property and confirmed that the OSGi tests pass. |
adutra
left a comment
There was a problem hiding this comment.
I will open an equivalent PR for the DSE driver.
No description provided.