JAVA-2263: Add optional schema validation#1300
Merged
Merged
Conversation
- resolve the final values (context or default) in the constructor and cache the results in fields. - expose this information on the public interface (might be useful for custom query providers). - use the default keyspace in `@Query` methods. - simplify error handling in `@Query` methods.
Contributor
Author
|
comments in closed branch: #1245 |
…hrow - log only warning because it may mean that Metadata is out of date
olim7t
reviewed
Jan 9, 2020
…with detailed message, and keyspace not present second
…va2263_rebase # Conflicts: # changelog/README.md # manual/mapper/mapper/README.md
this.keyspaceId defaults to the entity's default keyspace if the context doesn't specify any (see EntityHelperBase constructor). This is what we want here.
This made the validation code fail when run against DSE. getColumns() can be accessed on the parent interface.
olim7t
approved these changes
Jan 24, 2020
Contributor
|
I had a few more trivial remarks, I pushed the changes directly because I don't think they are controversial. |
…iver into java2263_rebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
todo:
isSchemaValidationEnabledinInventoryMapperBuilderto prevent backward compatibility problemsvoid validateColumnExists(TableMetadata table, String columnName, GenericType<?> javaType)