Conversation
Completed docs for: * Authentication * Control Connection * Reconnection * Statements * UDTs
olim7t
approved these changes
Jan 7, 2019
olim7t
left a comment
Contributor
There was a problem hiding this comment.
This looks great, I didn't catch any typo and the links all work.
The reconnection section needs a few adjustments for driver 3.
Contributor
Author
|
Thanks for the review and feedback. Will make the appropriate adjustments 👍 . |
adutra
reviewed
Jan 7, 2019
| ## Batch statements | ||
|
|
||
| *Coming soon... In the meantime, see the javadoc for [BatchStatement].* | ||
| Use [BatchStatement] to execute a set of queries as an atomic operation (refer to |
Contributor
There was a problem hiding this comment.
- Do we want to explain batch types (unlogged vs logged vs counter)?
- I think that "atomic" is only correct for a batch if all statements share the same partition key.
Contributor
Author
There was a problem hiding this comment.
I replaced 'atomic' with 'single'.
I also added a sentence about using UNLOGGED, I didn't mention COUNTER here its advanced and covered in CQL documentation, so should be apparent how to use it if needed.
Contributor
Author
There was a problem hiding this comment.
If you are ok with these changes I will follow on and also make them on 4.x.
adutra
approved these changes
Jan 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completed docs for:
For JAVA-1964. These are largely based on the 4.x docs, with the appropriate API changes and other details changed to match 3.x.