Repository navigation
Conversation
hsluoyz
requested changes
Nov 1, 2026
hsluoyz
left a comment
Member
There was a problem hiding this comment.
@EmryZhang we can publish all pending package releases in one vote Email, as suggested by mentors
| @@ -1,3 +1,20 @@ | |||
| # Licensed to the Apache Software Foundation (ASF) under one | |||
Member
There was a problem hiding this comment.
conf model files don't need to add header
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prepares the next Node-Casbin source release under the npm name
apache-casbin. It updates the committed version and package identity, legal files, dependency lock and publication workflow together, and incorporates the fixes merged since 5.51.1.Domain-pattern inference now requires positive mandatory matcher conditions tied to the actual role function and domain argument. Quoted text, optional branches and resource-path matching preserve exact-domain role isolation. Eleven regressions cover those cases and retain normal pattern matching and explicitly registered domain functions.
The release workflow keeps RCs out of npm, checks approved ASF originals before final packaging, and refuses asset replacement. Conformance fixtures are pinned to one revision; CI, coverage and final-package testing use the same inputs and disable install scripts. The new conformance test's original copyright sentence is retained in NOTICE.
Validation on Windows:
Dependency review retains one moderate minimatch advisory match: it requires
optimizationLevel >= 2; the library calls minimatch without options and the installed version defaults to level 1. Development-tool advisory paths are assessed separately. The review does not claim an advisory-free dependency graph.The archives used for these checks are unsigned local preparation inputs. After project review and merge, the actual merged commit, hosted CI and workflow candidate need verification before signing/staging and the applicable votes. Registry administration and final publication remain later release steps.