Repository navigation
feat: Improve performance of built-in-functions via static regexes - #249
Merged
Merged
Conversation
|
@EmperorYP7 @sheny1xuan @cs1137195420 please review |
cbaecker
force-pushed
the
perf/built-in-functions
branch
from
October 2, 2024 14:17
e2a49b0 to
6c17554
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Instantiation of
std::regexinvolves parsing and compiling the regular expression and should therefore be considered "expensive".In this PR I changed some constant
std::regexin the built-in-functions to static variables and moved those that are used multiple times to an anonymous namespace. I also introduced a few functions to reduce code duplication.In the specific use case, this was tested with 1000 different requests. These were structured in such a way that the entire policy had to be run through each time.
The time saving was around 40%.
casbintestruns about 25% faster.I tried to reflect functionality of the regex-expressions in the variable-names.
Testimonials
Unmodified version:
With this change: