[BEAM-7372] remove codepath and workaround for py2 from io#14292
Merged
tvalentyn merged 2 commits intoMar 25, 2021
Conversation
8b7b24c to
0e51f56
Compare
Contributor
Author
|
R: @tvalentyn |
Contributor
Author
|
Curiously codecov told that coverage is 0.00%, but actually 83.40% according to the report. |
tvalentyn
approved these changes
Mar 24, 2021
| # Avro RecordSchema provides field_map in py3 and fields_dict in py2 | ||
| field_map = getattr(parsed_schema, "field_map", None) or \ | ||
| getattr(parsed_schema, "fields_dict", None) | ||
| field_map = getattr(parsed_schema, "field_map", None) |
Contributor
There was a problem hiding this comment.
We can eliminate this variable
Contributor
|
I don't understand coverage error. If you want you can try to reproduce it on a smaller change. I'm happy to merge as is. |
Contributor
Author
|
Hmm, coverage check seems not to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed codepath for python2 with checking sys.version_info and also workarounds for it.
Usage of
futurepackage will be removed in another PR.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.