Repository navigation
reject invalid message length in MessageSerializer.readMessage - #1361
Open
Support-itecz wants to merge 1 commit into
Open
Support-itecz wants to merge 1 commit into
Support-itecz wants to merge 1 commit into
Conversation
Support-itecz
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
October 14, 2026 06:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
MessageSerializer.readMessagereads the 4-byte little-endian length prefix and hands it straight toByteBuffer.allocate(messageLength)without checking it. When a stream ends right after a continuation token (0xFFFFFFFF)messageLengthis left at -1, and a malformed prefix can carry any other negative value. Both reachByteBuffer.allocatewith a negative argument and throwIllegalArgumentException, which escapes theIOException/ end-of-stream contract thatArrowStreamReader,ArrowFileReaderandMessageChannelReaderrely on when reading untrusted input.Treat a continuation token with no following length as end-of-stream (return
null, matching how a short first read is already handled) and reject a negative length with anIOExceptionbefore the allocation. The guard sits inreadMessagebecause every IPC reader funnels through it.AI assistance was used to prepare this change; I reviewed the diff and test results before submitting.